[libcxx-commits] [PATCH] D112510: [libc++] P0433R2: add the remaining deduction guides.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const marked an inline comment as done.
var-const added inline comments.


================
Comment at: libcxx/test/std/numerics/numarray/template.valarray/valarray.cons/deduct.pass.cpp:45
+        std::valarray<long> v{1,2,3,4,5};
+        std::valarray v2 = v[std::slice(2,5,1)];
+        static_assert(std::is_same_v<decltype(v2), std::valarray<long>>);
----------------
Quuxplusone wrote:
> ASAN rightly complains because I forgot that the second argument is "size", not "end". Make this `std::slice(2,3,1)` and I think it'll be quiet.
Done, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112510/new/

https://reviews.llvm.org/D112510