[libcxx-commits] [PATCH] D112631: [libc++][test] Fix invalid test for views::view_interface

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Oct 27 14:12:08 PDT 2021


jloser added a comment.

In D112631#3091418 <https://reviews.llvm.org/D112631#3091418>, @cjdb wrote:

> There seems to be some confusion about whether or not this deviates from standard wording. It doesn't. I would very much prefer that our implementation catch user errors whenever we're in a position to do so, rather than let our users get false positives for a valid C++ program.

Agreed. I'm going to land this as-is for now, and I'll open a new review which adds a helpful `static_assert` to the member functions of `view_interface` soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112631/new/

https://reviews.llvm.org/D112631



More information about the libcxx-commits mailing list