[libcxx-commits] [PATCH] D112650: [libc++] Make __decay_copy constexpr

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__utility/decay_copy.h:27
 #if _LIBCPP_STD_VER > 17
     noexcept(is_nothrow_convertible_v<_Tp, remove_reference_t<_Tp> >)
 #endif
----------------
Quuxplusone wrote:
> jloser wrote:
> > jloser wrote:
> > > Mordante wrote:
> > > > jloser wrote:
> > > > > Nit: pre-existing, but can we remove the extra space to cuddle the `>>`, please?
> > > > Just FYI this is due to clang-tidy still being used in C++03 mode. We can change the clang-tidy language standard after switching to clang-tidy-13. (I expect make a patch for it real soon.)
> > > Thanks for the context. I'd definitely be in favor of that change. :)
> > Is `clang-tidy` even run on `libc++` CI?  It's mentioned in `libcxx/TODO.TXT` to run `clang-tidy` on `libc++`. I notice that  most llvm projects have their own `.clang-tidy` file, but `libc++` does not.
> Typo for `clang-format`, I assume. :) +1 for cuddling `>>`.
Note to self, don't read about clang-tidy while writing about clang-format ;-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112650/new/

https://reviews.llvm.org/D112650