[libcxx-commits] [PATCH] D112650: [libc++] Make __decay_copy constexpr

Wed Oct 27 12:35:31 PDT 2021

jloser added inline comments.

================
Comment at: libcxx/include/__utility/decay_copy.h:25
+_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR
+typename decay<_Tp>::type __decay_copy(_Tp&& __t)
 #if _LIBCPP_STD_VER > 17
----------------
I'm assuming this is used in C++11 code (thread and future) which is why we spell `typename decay<_Tp>::type` instead of `decay_t<_Tp>`?

================
Comment at: libcxx/include/__utility/decay_copy.h:27
 #if _LIBCPP_STD_VER > 17
     noexcept(is_nothrow_convertible_v<_Tp, remove_reference_t<_Tp> >)
 #endif
----------------
Nit: pre-existing, but can we remove the extra space to cuddle the `>>`, please?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112650/new/

https://reviews.llvm.org/D112650