[libcxx-commits] [PATCH] D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume.

Momchil Velikov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Oct 27 05:12:46 PDT 2021


chill added inline comments.


================
Comment at: libcxxabi/src/cxa_exception.cpp:383
     "	bl	__cxa_end_cleanup_impl\n"
-    "	pop	{r1, r2, r3, r4}\n"
-    "	bl	_Unwind_Resume\n"
-    "	bl	abort\n"
-    "	.popsection"
-);
+    "	pop	{r1, r2, r3, lr}\n"
+    "	b	_Unwind_Resume\n"
----------------
Could/should be
```
pop {r1, r2, r3, r4}
mov lr, r4
```
then it'll be compatible with Armv6-M and Armv8.0-M.base.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111703/new/

https://reviews.llvm.org/D111703



More information about the libcxx-commits mailing list