[libcxx-commits] [PATCH] D112553: [libc++] Make is_error_condition_enum_v and is_error_code_enum_v bool, not size_t

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 26 09:30:14 PDT 2021


Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

Arguably this should add a regression test. Certainly seems straightforward enough, though, right?
As usual I'm a little unsure of what the ABI implications are (notice `is_error_code_enum_v` is not `_LIBCPP_HIDE_FROM_ABI`), but this is also clearly a bugfix and I assume we'd bite the bullet if there were one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112553/new/

https://reviews.llvm.org/D112553



More information about the libcxx-commits mailing list