[libcxx-commits] [PATCH] D112126: [libunwind] Try to add -unwindlib=none while configuring and building libunwind

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Oct 25 13:34:59 PDT 2021


mstorsjo updated this revision to Diff 382110.
mstorsjo added a comment.

Factorized the tricky testing of `--unwindlib=none` to a separate cmake function, use this for the other similar-ish linker flags too.

I tried to mimic the naming and behaviour of the `check_c_compiler_flag` function, but should it be named more distinctly away from conflicting with possible future cmake core functions? And we could have the function append the tested flag directly to `CMAKE_REQUIRED_FLAGS` if succeeded too, instead of letting the caller do it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112126/new/

https://reviews.llvm.org/D112126

Files:
  libunwind/CMakeLists.txt
  libunwind/cmake/Modules/CheckCLinkerFlag.cmake
  libunwind/cmake/config-ix.cmake
  libunwind/src/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112126.382110.patch
Type: text/x-patch
Size: 4521 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211025/cda7cf17/attachment.bin>


More information about the libcxx-commits mailing list