[libcxx-commits] [PATCH] D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/charconv:606
+// standard. To keep both versions as similar as possible it's available in
+// earlier versions.
+#if _LIBCPP_STD_VER > 14
----------------
Mordante wrote:
> After moving the implementation to the dylib this reason isn't convincing anymore ;-)
> I still prefer to not make the code available prior to C++17 since that's our current policy.
> 
> @ldionne agreed or do you feel we should make this available in earlier versions?
I still think it should be available in C++17 and later only, to follow our policy.


================
Comment at: libcxx/src/CMakeLists.txt:2
 set(LIBCXX_LIB_CMAKEFILES_DIR "${CMAKE_CURRENT_BINARY_DIR}${CMAKE_FILES_DIRECTORY}"  PARENT_SCOPE)
+include_directories(${CMAKE_CURRENT_SOURCE_DIR})
 
----------------
Mordante wrote:
> @ldionne This seems to be required since not all build do this automatically.
> Should I make this a separate commit?
Yes, I believe this should be a separate commit. We also probably want to `target_include_directories` with `cxx_shared` and `cxx_static` instead of using `include_directories` globally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70631/new/

https://reviews.llvm.org/D70631