[libcxx-commits] [PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

[Daniel Kiss via Phabricator via libcxx-commits]

danielkiss added inline comments.


================
Comment at: libunwind/src/Registers.hpp:2245-2246
 
+  if (regNum == UNW_ARM_RA_AUTH_CODE)
+    return true;
+
----------------
Maybe we could gate this on __ARM_FEATURE_PAUTH because it won't work anyway without the feature enabled for libunwind.


================
Comment at: libunwind/src/Registers.hpp:2274-2275
 
+  if (regNum == UNW_ARM_RA_AUTH_CODE)
+    return _pseudo_registers.__pac;
+
----------------
ditto, maybe better to run into a `_LIBUNWIND_ABORT` instead debugging a silently skipping the authentication.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112430/new/

https://reviews.llvm.org/D112430