[libcxx-commits] [PATCH] D93233: [libc++] Replaces std::sort by Bitset sorting algorithm.

Nilay Vaish via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 12 17:29:12 PDT 2021


nilayvaish updated this revision to Diff 379230.
nilayvaish added a comment.

- Fixed the implementation.  No tests fail now: https://buildkite.com/llvm-project/libcxx-ci/builds/5917.
- Added _LIBCPP_HIDE_FROM_ABI to most functions.

Questions for ldionne@

- How do we test code size?
- Do we need to hide member functions in classes from the ABI?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93233/new/

https://reviews.llvm.org/D93233

Files:
  libcxx/include/__algorithm/nth_element.h
  libcxx/include/__algorithm/sort.h
  libcxx/include/__algorithm/stable_sort.h
  libcxx/src/CMakeLists.txt
  libcxx/src/legacy-sort.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93233.379230.patch
Type: text/x-patch
Size: 68646 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211013/7ac04207/attachment-0001.bin>


More information about the libcxx-commits mailing list