[libcxx-commits] [PATCH] D111514: [libc++] [P1614] Implement the second half of [cmp.alg]: compare_{strong, weak, partial}_fallback.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, libc++, rarutyun, jloser, Mordante.
Quuxplusone added a project: libc++.
Herald added a subscriber: mgorny.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

The tests for these are just copy-pasted from the tests for `std::{strong,weak,partial}_order`, and then I added an extra clause in each (`test_2()`) to test the stuff that's not just the same as `std::*_order`.
This also includes the fix for https://wg21.link/LWG3465 (which falls naturally out of the "you must write it three times" style, but I've added test cases for it also).

Depends on D110738 <https://reviews.llvm.org/D110738>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111514

Files:
  libcxx/docs/Status/Cxx2bIssues.csv
  libcxx/include/CMakeLists.txt
  libcxx/include/__compare/compare_partial_order_fallback.h
  libcxx/include/__compare/compare_strong_order_fallback.h
  libcxx/include/__compare/compare_weak_order_fallback.h
  libcxx/include/compare
  libcxx/include/module.modulemap
  libcxx/test/libcxx/diagnostics/detail.headers/compare/compare_partial_order_fallback.module.verify.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/compare/compare_strong_order_fallback.module.verify.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/compare/compare_weak_order_fallback.module.verify.cpp
  libcxx/test/std/language.support/cmp/cmp.alg/compare_partial_order_fallback.pass.cpp
  libcxx/test/std/language.support/cmp/cmp.alg/compare_strong_order_fallback.pass.cpp
  libcxx/test/std/language.support/cmp/cmp.alg/compare_weak_order_fallback.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111514.378530.patch
Type: text/x-patch
Size: 95411 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211010/dfc569b5/attachment-0001.bin>