[libcxx-commits] [PATCH] D110738: [libc++] [P1614] Implement the first half of [cmp.alg]: strong_order, weak_order, partial_order.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Oct 8 15:00:35 PDT 2021


Quuxplusone updated this revision to Diff 378365.
Quuxplusone marked 3 inline comments as done.
Quuxplusone added a comment.

Rename `_PriorityTag` to `__priority_tag`.
In `partial_order.pass.cpp`, work around GCC's inability to compare NaN against non-NaN at compile time.
I bet this still needs a bunch of `UNSUPPORTED: libcpp-no-concepts` etc. for Apple; I'll let buildkite tell me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110738/new/

https://reviews.llvm.org/D110738

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__compare/partial_order.h
  libcxx/include/__compare/strong_order.h
  libcxx/include/__compare/weak_order.h
  libcxx/include/__utility/priority_tag.h
  libcxx/include/compare
  libcxx/include/module.modulemap
  libcxx/include/utility
  libcxx/test/libcxx/diagnostics/detail.headers/compare/partial_order.module.verify.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/compare/strong_order.module.verify.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/compare/weak_order.module.verify.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/utility/priority_tag.module.verify.cpp
  libcxx/test/std/language.support/cmp/cmp.alg/partial_order.pass.cpp
  libcxx/test/std/language.support/cmp/cmp.alg/strong_order.pass.cpp
  libcxx/test/std/language.support/cmp/cmp.alg/weak_order.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110738.378365.patch
Type: text/x-patch
Size: 84082 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211008/2694255f/attachment-0001.bin>


More information about the libcxx-commits mailing list