[libcxx-commits] [PATCH] D88458: [CMake] Cache the compiler-rt library search results

Wed Oct 6 02:11:12 PDT 2021

phosek added a comment.

In D88458#3040347 <https://reviews.llvm.org/D88458#3040347>, @ldionne wrote:

> In D88458#3032086 <https://reviews.llvm.org/D88458#3032086>, @phosek wrote:
>
>> Is there any objection to landing this change as is and addressing the licensing aspect later in a separate change?
>
> IMO that's reasonable, let's not hold this change back -- the lack of a top-level license in some subdirectories is a pre-existing condition, so when we decide what to do about that issue, we can solve it for all subdirectories.
>
> I'd like to see CI passing before we ship this though.

Done, I believe I've also addressed PR51389 which was the reason for the failing build on Darwin.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88458/new/

https://reviews.llvm.org/D88458