[libcxx-commits] [PATCH] D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf

[Mark de Wever via Phabricator via libcxx-commits]

Mordante planned changes to this revision.
Mordante added inline comments.


================
Comment at: libcxx/include/charconv:606
+// standard. To keep both versions as similar as possible it's available in
+// earlier versions.
+#if _LIBCPP_STD_VER > 14
----------------
After moving the implementation to the dylib this reason isn't convincing anymore ;-)
I still prefer to not make the code available prior to C++17 since that's our current policy.

@ldionne agreed or do you feel we should make this available in earlier versions?


================
Comment at: libcxx/src/CMakeLists.txt:2
 set(LIBCXX_LIB_CMAKEFILES_DIR "${CMAKE_CURRENT_BINARY_DIR}${CMAKE_FILES_DIRECTORY}"  PARENT_SCOPE)
+include_directories(${CMAKE_CURRENT_SOURCE_DIR})
 
----------------
@ldionne This seems to be required since not all build do this automatically.
Should I make this a separate commit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70631/new/

https://reviews.llvm.org/D70631