[libcxx-commits] [PATCH] D112348: [libcxx] [test] Narrow down XFAILs regarding a MSVC mode specific bug to "windows-dll && msvc"

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added a reviewer: ldionne.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

These tests don't fail when only windows-dll is set in mingw mode, as the
bug is specific to MSVC mode.

Split this one out from D112211 <https://reviews.llvm.org/D112211>, as this one is even clearer.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112348

Files:
  libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
  libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
  libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
  libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp


Index: libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
===================================================================
--- libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
+++ libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // https://llvm.org/PR41018
-// XFAIL: windows-dll
+// XFAIL: windows-dll && msvc
 
 // <locale>
 
Index: libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // https://llvm.org/PR41018
-// XFAIL: windows-dll
+// XFAIL: windows-dll && msvc
 
 // <locale>
 
Index: libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // https://llvm.org/PR41018
-// XFAIL: windows-dll
+// XFAIL: windows-dll && msvc
 
 // <locale>
 
Index: libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
@@ -9,7 +9,7 @@
 // REQUIRES: locale.en_US.UTF-8
 
 // https://llvm.org/PR41018
-// XFAIL: windows-dll
+// XFAIL: windows-dll && msvc
 
 // <locale>
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112348.381664.patch
Type: text/x-patch
Size: 2322 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211022/7f1712fc/attachment.bin>