[libcxx-commits] [libcxx] f5ee1ac - [libcxx] [test] Convert an XFAIL: LIBCXX-WINDOWS-FIXME into XFAIL: msvc with explanation

Martin Storsjö via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 21 15:02:42 PDT 2021


Author: Martin Storsjö
Date: 2021-10-22T01:02:25+03:00
New Revision: f5ee1acc62d5a5052fc2ca65cf2f2927a3c6e9c2

URL: https://github.com/llvm/llvm-project/commit/f5ee1acc62d5a5052fc2ca65cf2f2927a3c6e9c2
DIFF: https://github.com/llvm/llvm-project/commit/f5ee1acc62d5a5052fc2ca65cf2f2927a3c6e9c2.diff

LOG: [libcxx] [test] Convert an XFAIL: LIBCXX-WINDOWS-FIXME into XFAIL: msvc with explanation

This test doesn't fail in mingw mode (which uses the same Itanium
name mangling and ABI as other platforms).

Differential Revision: https://reviews.llvm.org/D112210

Added: 
    

Modified: 
    libcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.merged.sh.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.merged.sh.cpp b/libcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.merged.sh.cpp
index cd742a6f09075..da82ea1d2c388 100644
--- a/libcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.merged.sh.cpp
+++ b/libcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.merged.sh.cpp
@@ -8,7 +8,8 @@
 
 // UNSUPPORTED: no-rtti
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// In MSVC mode, the two anonymous types have identical type index in both object files.
+// XFAIL: msvc
 
 // RUN: %{cxx} %s %{flags} %{compile_flags} -c -o %t.tu1.o -DTU1 -D_LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION=1
 // RUN: %{cxx} %s %{flags} %{compile_flags} -c -o %t.tu2.o -DTU2 -D_LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION=1


        


More information about the libcxx-commits mailing list