[libcxx-commits] [PATCH] D111947: [Demangle] Rename OutputStream to OutputString

Thu Oct 21 13:19:50 PDT 2021

dblaikie added inline comments.

================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:15
-#ifndef LLVM_DEMANGLE_ITANIUMDEMANGLE_H
-#define LLVM_DEMANGLE_ITANIUMDEMANGLE_H

----------------
ljmf00 wrote:
> dblaikie wrote:
> > ljmf00 wrote:
> > > Geod24 wrote:
> > > > Why those changes ? IIUC the CI is failing on this file, too.
> > > This is because the script was verbatim copied. I think LLVM should address this in a more clean way, to be honest. These specific files are literally copied from one place to another and stuff like this can happen without being noticed. @dblaikie Currently, there is an effort to change this or any specific rationale to keep it this way?
> > Not quite following - but no, I don't think there's any effort at the moment to change this situation that these two files need to be kept in sync.
> Those files need to be manually copied and manually changed to prevent the usage of the same include guard. This can be improved by e.g. generate a copy of this file with a generator script on the build system. I asked if there is any rationale to have it this way.
Still not sure I'm following/understanding the question. If you mean: Is there any reason this is manual rather than automated? I doubt it, only that no one's managed to automate it yet, perhaps.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111947/new/

https://reviews.llvm.org/D111947