[libcxx-commits] [PATCH] D111961: [libc++] Use addressof in vector.
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Oct 21 09:32:11 PDT 2021
Mordante marked an inline comment as done.
Mordante added a comment.
For now I keep the minimal set of tests; there are still quite some headers to review left ;-)
================
Comment at: libcxx/include/vector:1740
+ _LIBCPP_ASSERT(__get_const_db()->__find_c_from_i(_VSTD::addressof(__last)) == this,
"vector::erase(iterator, iterator) called with an iterator not"
" referring to this vector");
----------------
Quuxplusone wrote:
> Pre-existing: `iterator, iterator` should be `iterator, iterator` (but that'll require updating tests, and should be a separate commit anyway)
I created D112231, it seems not to affect tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111961/new/
https://reviews.llvm.org/D111961
More information about the libcxx-commits
mailing list