[libcxx-commits] [PATCH] D112086: [libc++][AIX] Do not assert chmod return value is non-zero.
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Oct 21 08:34:28 PDT 2021
ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.
================
Comment at: libcxx/test/support/filesystem_test_helper.h:145-148
+ // On AIX the chmod command will return non-zero when trying to set
+ // the permissions on a directory that contains a bad symlink. This triggers
+ // the assert, despite being able to delete everything with the following
+ // `rm -r` command.
----------------
Please align the comment with the code. Also, we always indent with spaces, not tabs (in case that's the issue).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112086/new/
https://reviews.llvm.org/D112086
More information about the libcxx-commits
mailing list