[libcxx-commits] [PATCH] D112210: [libcxx] [test] Convert an XFAIL: LIBCXX-WINDOWS-FIXME into XFAIL: msvc with explanation

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.merged.sh.cpp:11
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// In MSVC mode, the two anonymous types have identical type index in both object files.
+// XFAIL: msvc
----------------
ldionne wrote:
> Isn't that a bug we need to fix?
AFAIK this is not something that “we” as in libc++ can fix, it’s a property of the msvc C++ ABI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112210/new/

https://reviews.llvm.org/D112210