[libcxx-commits] [PATCH] D112210: [libcxx] [test] Convert an XFAIL: LIBCXX-WINDOWS-FIXME into XFAIL: msvc with explanation

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added a reviewer: ldionne.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

This test doesn't fail in mingw mode (which uses the same Itanium
name mangling and ABI as other platforms).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112210

Files:
  libcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.merged.sh.cpp


Index: libcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.merged.sh.cpp
===================================================================
--- libcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.merged.sh.cpp
+++ libcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.merged.sh.cpp
@@ -8,7 +8,8 @@
 
 // UNSUPPORTED: no-rtti
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// In MSVC mode, the two anonymous types have identical type index in both object files.
+// XFAIL: msvc
 
 // RUN: %{cxx} %s %{flags} %{compile_flags} -c -o %t.tu1.o -DTU1 -D_LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION=1
 // RUN: %{cxx} %s %{flags} %{compile_flags} -c -o %t.tu2.o -DTU2 -D_LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION=1


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112210.381200.patch
Type: text/x-patch
Size: 776 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211021/e08c3dae/attachment.bin>