[libcxx-commits] [PATCH] D111672: [runtimes] Properly handle the sysroot/triple/gcc-toolchain

Thu Oct 21 01:52:03 PDT 2021

phosek added a comment.

In D111672#3073648 <https://reviews.llvm.org/D111672#3073648>, @ldionne wrote:

> In D111672#3071246 <https://reviews.llvm.org/D111672#3071246>, @phosek wrote:
>
>> I wonder if we can deprecate `LIBCXX_TARGET_TRIPLE`, `LIBCXX_SYSROOT`, and `LIBCXX_GCC_TOOLCHAIN` (and their libc++abi and libunwind counterparts), and switch to the CMake variables instead? Do those custom variables give us anything?
>
> I thought you added those variables for the Bootstrapping build? I'm more than happy to remove them if you don't need them.

I don't think they should be needed anymore, but it's possible that other parts of the build depend on them. In any case, this can be addressed in a follow up change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111672/new/

https://reviews.llvm.org/D111672