[libcxx-commits] [PATCH] D110110: [libc++] [ABI BREAK] Remove non-atomic "platform" semaphore implementations.

[Olivier Giroux via Phabricator via libcxx-commits]

__simt__ added a comment.

Hmm. I lost track of how/when this constructor got defined as constexpr. It doesn't mean that it's unimplementable with platform semaphores, but to do so would make the implementation a lot more complicated, slower, and the object even larger than it already is.

I note that the MSVC STL also implemented semaphores exclusively on atomics, like this.

I'm personally pretty comfortable with this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110110/new/

https://reviews.llvm.org/D110110