[libcxx-commits] [PATCH] D112092: [libc++] LWG3001: add `remove_extent_t` to `weak_ptr::element_type`.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D112092#3076034 <https://reviews.llvm.org/D112092#3076034>, @Quuxplusone wrote:

> LGTM at this point modulo all the `>= 17` that need to be `> 14`, and that we should see buildkite passing successfully before landing this.

I'll mention that I actually suggested doing that to @var-const to see if it would fly with the other reviewers. We've definitely been using `VER > n` as a convention in libc++ and the test suite, that's one of the few places where we're pretty consistent. However, I've always found it a bit weird and IMO it would be more natural to use `>=`. @Quuxplusone Would you (or someone else lurking on this review) oppose to making such a change? If so, why?

This is 100% orthogonal to the actual review -- I suggest @var-const just reverts to using `>` for getting this patch landed, and we can settle on this question separately. I'm just curious to see where that discussion leads us.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112092/new/

https://reviews.llvm.org/D112092