[libcxx-commits] [PATCH] D112112: [libunwind] Link with -unwindlib=none

[Harald van Dijk via Phabricator via libcxx-commits]

hvdijk abandoned this revision.
hvdijk added a comment.

In D112112#3076272 <https://reviews.llvm.org/D112112#3076272>, @mstorsjo wrote:

> If sidestepping this issue a little - if you'd only add those `*_WORKS` flags to libunwind, do things work there too?
>
> When running into this error in compiler-rt, were you pointing cmake at `compiler-rt/lib/builtins` or plain `compiler-rt`?

That will be the relevant difference, thanks. I was pointing to compiler-rt and explicitly setting `-DCOMPILER_RT_BUILD_SANITIZERS=OFF -DCOMPILER_RT_BUILD_XRAY=OFF -DCOMPILER_RT_BUILD_LIBFUZZER=OFF -DCOMPILER_RT_BUILD_PROFILE=OFF -DCOMPILER_RT_BUILD_MEMPROF=OFF -DCOMPILER_RT_BUILD_ORC=OFF`. I'll try soon whether configuring from `lib/builtins` directly, and using `*_WORKS` for libunwind, works for me too, but based on what you've said so far, if it doesn't yet, I'm sure we can find a way to make it work. I'm happy to pre-emptively abandon this revision, will follow up on yours once I can verify that everything works.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112112/new/

https://reviews.llvm.org/D112112