[libcxx-commits] [PATCH] D112068: [libcxx] Throw correct exception from std::vector::reserve

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Oct 20 11:04:08 PDT 2021


Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

LGTM now! (Of course now D112150 <https://reviews.llvm.org/D112150> blocks this one: but hey, good, we fixed another bug too. :))



================
Comment at: libcxx/test/std/containers/sequences/vector.bool/reserve.pass.cpp:67
+            // In libc++ the chunk has the same size as the machine word. It is
+            // resonable to assume that in practice no implementation would use
+            // 64 kB or larger chunks.
----------------
`reasonable`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112068/new/

https://reviews.llvm.org/D112068



More information about the libcxx-commits mailing list