[libcxx-commits] [PATCH] D112092: [libc++] LWG3001: add `remove_extent_t` to `weak_ptr::element_type`.

[Joe Loser via Phabricator via libcxx-commits]

jloser added inline comments.


================
Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.weak/types.pass.cpp:33
+#if TEST_STD_VER > 17
+  static_assert(
+      std::is_same<typename std::weak_ptr<T[]>::element_type, T>::value, "");
----------------
Why not use `ASSERT_SAME_TYPE` to be consistent instead of mixed use of `ASSERT_SAME_TYPE` and `std::is_same`? BTW, you could use `std::is_same_v` since this block is C++17 code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112092/new/

https://reviews.llvm.org/D112092