[libcxx-commits] [PATCH] D111598: [libc++][docs] Mark LWG3420 complete

Tue Oct 19 06:53:48 PDT 2021

jloser added a comment.

In D111598#3060264 <https://reviews.llvm.org/D111598#3060264>, @jloser wrote:

> In D111598#3058500 <https://reviews.llvm.org/D111598#3058500>, @ldionne wrote:
>
>> LGTM, but can you confirm we have a test for that? Also, the commit you linked to isn't the right one, 120fa8293e22f760374a5757d081dc674046e0f0 <https://reviews.llvm.org/rG120fa8293e22f760374a5757d081dc674046e0f0> is just moving stuff around. You should fix the commit message.
>
> `__cpp17_iterator` seems to get used pretty heavily in `libcxx/test/libcxx/iterators/iterator.requirements/iterator.assoc.types/iterator.traits/legacy_iterator.compile.pass.cpp`. Is this what you had in mind or something more specific?

@ldionne I just landed this, but if you think of a test you'd like to see (beyond what we have now), let me know.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111598/new/

https://reviews.llvm.org/D111598