[libcxx-commits] [PATCH] D96408: Fix warnings when compiling libcxx for Windows with clang-cl /W4

[Colin Finck via Phabricator via libcxx-commits]

ColinFinck updated this revision to Diff 380602.
ColinFinck added a comment.

Apply suggestions from @Quuxplusone


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96408/new/

https://reviews.llvm.org/D96408

Files:
  libcxx/src/atomic.cpp
  libcxx/src/support/win32/locale_win32.cpp


Index: libcxx/src/support/win32/locale_win32.cpp
===================================================================
--- libcxx/src/support/win32/locale_win32.cpp
+++ libcxx/src/support/win32/locale_win32.cpp
@@ -16,7 +16,7 @@
 using std::__libcpp_locale_guard;
 
 // FIXME: base currently unused. Needs manual work to construct the new locale
-locale_t newlocale( int mask, const char * locale, locale_t /*base*/ )
+locale_t newlocale( int /*mask*/, const char * locale, locale_t /*base*/ )
 {
     return {_create_locale( LC_ALL, locale ), locale};
 }
Index: libcxx/src/atomic.cpp
===================================================================
--- libcxx/src/atomic.cpp
+++ libcxx/src/atomic.cpp
@@ -117,12 +117,14 @@
         // We only call 'wake' if we consumed a contention bit here.
         __libcpp_platform_wake_by_address(__platform_state, __notify_one);
 }
-static __cxx_contention_t __libcpp_contention_monitor_for_wait(__cxx_atomic_contention_t volatile* __contention_state,
+
+static __cxx_contention_t __libcpp_contention_monitor_for_wait(__cxx_atomic_contention_t volatile* /*__contention_state*/,
                                                                __cxx_atomic_contention_t const volatile* __platform_state)
 {
     // We will monitor this value.
     return __cxx_atomic_load(__platform_state, memory_order_acquire);
 }
+
 static void __libcpp_contention_wait(__cxx_atomic_contention_t volatile* __contention_state,
                                      __cxx_atomic_contention_t const volatile* __platform_state,
                                      __cxx_contention_t __old_value)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96408.380602.patch
Type: text/x-patch
Size: 1621 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211019/29b00938/attachment.bin>