[libcxx-commits] [PATCH] D112031: [libc++] Move LIBCXX-DEBUG-FIXME to params.py

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
Herald added subscribers: arichardson, mgorny.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This temporary FIXME really belongs to the testing config, not to the
specific CMake cache that enables that configuration.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112031

Files:
  libcxx/cmake/caches/Generic-debug-iterators.cmake
  libcxx/utils/libcxx/test/params.py


Index: libcxx/utils/libcxx/test/params.py
===================================================================
--- libcxx/utils/libcxx/test/params.py
+++ libcxx/utils/libcxx/test/params.py
@@ -125,7 +125,8 @@
             help="The debugging level to enable in the test suite.",
             actions=lambda debugLevel: [] if debugLevel == '' else [
               AddFeature('debug_level={}'.format(debugLevel)),
-              AddCompileFlag('-D_LIBCPP_DEBUG={}'.format(debugLevel))
+              AddCompileFlag('-D_LIBCPP_DEBUG={}'.format(debugLevel)),
+              AddFeature('LIBCXX-DEBUG-FIXME') if debugLevel == '1'
             ]),
 
   Parameter(name='use_sanitizer', choices=['', 'Address', 'Undefined', 'Memory', 'MemoryWithOrigins', 'Thread', 'DataFlow', 'Leaks'], type=str, default='',
Index: libcxx/cmake/caches/Generic-debug-iterators.cmake
===================================================================
--- libcxx/cmake/caches/Generic-debug-iterators.cmake
+++ libcxx/cmake/caches/Generic-debug-iterators.cmake
@@ -1,2 +1,2 @@
-set(LIBCXX_TEST_PARAMS "debug_level=1" "additional_features=LIBCXX-DEBUG-FIXME" CACHE STRING "")
+set(LIBCXX_TEST_PARAMS "debug_level=1" CACHE STRING "")
 set(LIBCXXABI_TEST_PARAMS "${LIBCXX_TEST_PARAMS}" CACHE STRING "")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112031.380508.patch
Type: text/x-patch
Size: 1272 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211018/4d31d753/attachment.bin>