[libcxx-commits] [PATCH] D111926: [libc++][doc] Use sphinx variables to make updating the docs version easier

Mon Oct 18 13:05:20 PDT 2021

ldionne added a comment.

In D111926#3071164 <https://reviews.llvm.org/D111926#3071164>, @tstellar wrote:

> In D111926#3071076 <https://reviews.llvm.org/D111926#3071076>, @tstellar wrote:
>
>> In D111926#3071070 <https://reviews.llvm.org/D111926#3071070>, @ldionne wrote:
>>
>>> The intent of the change looks good to me, i.e. using variables to set the version number & al.
>>>
>>> However, I checked out this patch and built the documentation, and it doesn't show "In Progress" anymore, nor does it have any mention of being the libc++ 14.0.0 incoming release. Is that intended? IMO, it was useful to have that visual marker about notes being in-progress release notes for an upcoming release.
>>
>> It's not intended.  I will try to reproduce with your build configuration.
>
> It looks like the runtime builds don't have access to the LLVM_VERSION* cmake variables, which is why the version information is missing.  I think I'll try to convert some of the non-runtime sub-projects first and then revisit libcxx once I'm done with those.

Alright, sounds good to me. Sorry our build system migration is clashing with this effort, but at least it's good that we're aware of it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111926/new/

https://reviews.llvm.org/D111926