[libcxx-commits] [PATCH] D111892: Raise assertion error when using unimplemented functions

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I agree it's weird we have those declarations but no implementation for them. I think my preferred approach here would be to just comment out those functions. That way, we know for sure we won't interact in weird ways with SFINAE or anything.

Commenting out the functions is what's closest to just not having implementing them (which is what's going on here).

Apart from that, LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111892/new/

https://reviews.llvm.org/D111892