[libcxx-commits] [PATCH] D111947: [Demangle] Rename OutputStream to OutputString
Luís Ferreira via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Oct 17 11:47:33 PDT 2021
ljmf00 added inline comments.
================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:15
-#ifndef LLVM_DEMANGLE_ITANIUMDEMANGLE_H
-#define LLVM_DEMANGLE_ITANIUMDEMANGLE_H
----------------
Geod24 wrote:
> Why those changes ? IIUC the CI is failing on this file, too.
This is because the script was verbatim copied. I think LLVM should address this in a more clean way, to be honest. These specific files are literally copied from one place to another and stuff like this can happen without being noticed. @dblaikie Currently, there is an effort to change this or any specific rationale to keep it this way?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111947/new/
https://reviews.llvm.org/D111947
More information about the libcxx-commits
mailing list