[libcxx-commits] [PATCH] D110501: [libc++][format] Adds formatting benchmarks.

[Victor Zverovich via Phabricator via libcxx-commits]

vitaut added a comment.

Minor comment inline, otherwise LGTM.



================
Comment at: libcxx/benchmarks/format_to.bench.cpp:52
+
+template <class Span>
+static void BM_format_to_string_span(benchmark::State& state) {
----------------
Why pass `Span` as a template parameter instead of the character type?


================
Comment at: libcxx/benchmarks/format_to.bench.cpp:64
+
+template <class Pointer>
+static void BM_format_to_string_pointer(benchmark::State& state) {
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110501/new/

https://reviews.llvm.org/D110501