[libcxx-commits] [PATCH] D111838: [libc++] Implement LWG3369, tweak CTAD for std::span.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

LGTM!



================
Comment at: libcxx/test/std/containers/views/span.cons/deduct.pass.cpp:56-58
     int arr[] = {1, 2, 3};
     std::span s{arr};
     ASSERT_SAME_TYPE(decltype(s), std::span<int, 3>);
----------------
Quuxplusone wrote:
> @Mordante: I believe this is the exact test case displayed in https://cplusplus.github.io/LWG/issue3369 — and yeah, I assume it passes anyway because of that Clang bug. I don't have the capability to test libc++ with non-Clang compilers to see if it fails... although I confess I don't understand why this test passes even with the gcc buildkite.
That's indeed the same test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111838/new/

https://reviews.llvm.org/D111838