[libcxx-commits] [PATCH] D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf

[Mark de Wever via Phabricator via libcxx-commits]

Mordante planned changes to this revision.
Mordante added a comment.

In D70631#3068686 <https://reviews.llvm.org/D70631#3068686>, @jorgbrown wrote:

> In D70631#3068541 <https://reviews.llvm.org/D70631#3068541>, @Mordante wrote:
>
>> Replaced _Bit_cast with std::bit_cast
>
> Umm, not sure that's a good idea... std::bit_cast is c++20 whereas std::to_chars is c++17.

`std::bit_cast` is indeed C++20. This is safe since the dylib is always compiled in C++20 mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70631/new/

https://reviews.llvm.org/D70631