[libcxx-commits] [PATCH] D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf

Jorg Brown via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Oct 16 13:39:57 PDT 2021


jorgbrown added a comment.

In D70631#3068541 <https://reviews.llvm.org/D70631#3068541>, @Mordante wrote:

> Move the entire to_char floating-point implementation to the dylib

Great to see more stuff moving to the library!

> Replaced _Bit_cast with std::bit_cast

Umm, not sure that's a good idea... std::bit_cast is c++20 whereas std::to_chars is c++17.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70631/new/

https://reviews.llvm.org/D70631



More information about the libcxx-commits mailing list