[libcxx-commits] [PATCH] D111926: [libc++][doc] Use sphinx variables to make updating the docs version easier

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/docs/ReleaseNotes.rst:15
    Release notes for previous releases can be found on
    `the Download Page <https://releases.llvm.org/download.html>`_.
 
----------------
Would it be possible to automatically remove this block, including the `.. warning::` at line 11, when the version is a release?


================
Comment at: libcxx/docs/conf.py:54
 # The full version, including alpha/beta/rc tags.
-release = '14.0'
+release = version + 'git'
 
----------------
The current output "libc++ 14.0.0git documentation" looks weird.


================
Comment at: libcxx/docs/conf.py:54
 # The full version, including alpha/beta/rc tags.
-release = '14.0'
+release = version + 'git'
 
----------------
Mordante wrote:
> The current output "libc++ 14.0.0git documentation" looks weird.
I expect for a release I'd have to remove `+ 'git'`, but doing so results in errors when building the documentation.
```
make[3]: *** [projects/libcxx/docs/CMakeFiles/docs-libcxx-html.dir/build.make:58: projects/libcxx/docs/CMakeFiles/docs-libcxx-html] Error 2
make[2]: *** [CMakeFiles/Makefile2:25091: projects/libcxx/docs/CMakeFiles/docs-libcxx-html.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:25098: projects/libcxx/docs/CMakeFiles/docs-libcxx-html.dir/rule] Error 2
make: *** [Makefile:7544: docs-libcxx-html] Error 2
```
Do I misunderstand the intention or is there a real error?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111926/new/

https://reviews.llvm.org/D111926