[libcxx-commits] [PATCH] D111892: [SystemZ][z/OS] Raise assertion error when using unimplemented functions

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

Above my pay grade, but...

(1) Isn't a runtime error vastly //less// user-friendly than a link-time error? Perhaps you could show an example of the kind of program that would run into this linker error and/or assertion?
(2) Is a plain `assert` really more appropriate than either `_LIBCPP_ASSERT` or `throw`? (I think `_LIBCPP_ASSERT` would be less appropriate because it compiles away in non-debug modes; but then, so does regular `assert` in `NDEBUG` mode.)
(3) Alternatively, how about either just commenting-out, or `=delete`'ing, these functions, to turn the linker error into a compile-time (and SFINAE'able) ill-formedness?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111892/new/

https://reviews.llvm.org/D111892