[libcxx-commits] [PATCH] D111458: [libc++][doc] Use issue labels.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the reviews. I'll look at tagging more issues for a separate review.



================
Comment at: libcxx/docs/Status/Cxx2bIssues.csv:116
+`3535 <https://wg21.link/LWG3535>`__,"``join_view::iterator::iterator_category`` and ``::iterator_concept`` lie","October 2021","","","|ranges|"
 `3554 <https://wg21.link/LWG3554>`__,"``chrono::parse`` needs ``const charT*`` and ``basic_string_view<charT>`` overloads","October 2021","",""
 `3557 <https://wg21.link/LWG3557>`__,"The ``static_cast`` expression in ``convertible_to`` has the wrong operand","October 2021","",""
----------------
Quuxplusone wrote:
> Should this say `|chrono| |format|`? (Incidentally, I'd prefer this alphabetical order over your `|format| |chrono|`; but not a blocker.)
As mentioned in the description I'd like to mark additional papers in a separate commit. Then I also want to look for spaceship related issues to be marked. I prefer to get the initial part in first to avoid getting merge conflicts (I'm sure I already have some).

I put `|format| |chrono|` in this order since it's logical to me, but I agree alphabetic order is better. I'll fix that prior to committing; one regex replacement and I'm done ;-)


================
Comment at: libcxx/docs/Status/RangesIssues.csv:2-30
 `P0896R4 <https://wg21.link/P0896R4>`__,<ranges>,,
 `P1035R7 <https://wg21.link/P1035R7>`__,Input Range Adaptors,,
 `P1207R4 <https://wg21.link/P1207R4>`__,Movability Of Single-Pass Iterators,,
 `P1243R4 <https://wg21.link/P1243R4>`__,Rangify New Algorithms,,
 `P1248R1 <https://wg21.link/P1248R1>`__,Fixing Relations,,
 `P1252R2 <https://wg21.link/P1252R2>`__,Ranges Design Cleanup,,
 `P1391R4 <https://wg21.link/P1391R4>`__,Range Constructor For string_view,,
----------------
ldionne wrote:
> It looks like we'll need to figure out what to do with those. I think they should just be moved to the appropriate `CXXNPapers` page and tagged with `|ranges|`. WDYT? This is fine to do in a separate commit, though.
For implementing format I found it very useful to have the papers still available. So I prefer to keep them. A slightly longer answer is here https://reviews.llvm.org/D111458#inline-1062734. But we can discuss that post commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111458/new/

https://reviews.llvm.org/D111458