[libcxx-commits] [PATCH] D111748: [CMake] Set the CMP0114 policy

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D111748#3063987 <https://reviews.llvm.org/D111748#3063987>, @ldionne wrote:

> I'm using `cmake version 3.20.3` and I don't think I've seen any warning so far. What happens on your side that prompted you to make this change?

We see a lot of the following warning:

  CMake Warning (dev) at /b/s/w/ir/x/w/cipd/share/cmake-3.19/Modules/ExternalProject.cmake:2240 (message):
    Policy CMP0114 is not set: ExternalProject step targets fully adopt their
    steps.  Run "cmake --help-policy CMP0114" for policy details.  Use the
    cmake_policy command to set the policy and suppress this warning.
  
    ExternalProject target 'stage2' would depend on the targets for step(s)
    'really-install' under policy CMP0114, but this is being left out for
    compatibility since the policy is not set.
  Call Stack (most recent call first):
    /b/s/w/ir/x/w/llvm-project/clang/CMakeLists.txt:858 (ExternalProject_Add_StepTargets)
  This warning is for project developers.  Use -Wno-dev to suppress it.

Here's an example: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8833340663294366177/+/u/clang/configure/stdout


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111748/new/

https://reviews.llvm.org/D111748