[libcxx-commits] [PATCH] D111845: [libc++] LWG3266: delete the to_chars(bool) overload.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const created this revision.
var-const added a reviewer: ldionne.
var-const requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This PR only updates the synopsis in `<charconv>` -- the current
implementation already deletes <https://github.com/llvm/llvm-project/blob/e9e6266c704df43e2c52308e1b653dccefa89e04/libcxx/include/charconv#L108>
the overload and has a test <https://github.com/llvm/llvm-project/blob/main/libcxx/test/std/utilities/charconv/charconv.to.chars/integral.bool.fail.cpp>
for it (and this has been the case from the first commit <https://reviews.llvm.org/D41458>
where `<charconv>` was added).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111845

Files:
  libcxx/include/charconv


Index: libcxx/include/charconv
===================================================================
--- libcxx/include/charconv
+++ libcxx/include/charconv
@@ -31,6 +31,8 @@
 
   to_chars_result to_chars(char* first, char* last, see below value,
                            int base = 10);
+  to_chars_result to_chars(char* first, char* last, bool value,
+                           int base = 10) = delete;
 
   to_chars_result to_chars(char* first, char* last, float value);
   to_chars_result to_chars(char* first, char* last, double value);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111845.379859.patch
Type: text/x-patch
Size: 544 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211014/69425479/attachment.bin>