[libcxx-commits] [PATCH] D111356: [runtimes] Use the new "runtimes" build by default and deprecate other builds

Thu Oct 14 14:25:42 PDT 2021

bcain added a comment.

In D111356#3064401 <https://reviews.llvm.org/D111356#3064401>, @ldionne wrote:

> I haven't seen a lot of discussion on this, either here or on the lists where I posted my RFC. Does this sounds reasonable to you all?
>
> Pinging @tstellar and @bcain in particular because I think they are using standalone builds at the moment, and I want to have their blessing that this is going to work for them. Actually folks, you could move to the new "default" build right away to try it out if you wanted.

Louis, thanks so much for sending the notice to llvm-dev, it will really help us plan for this change.  We needed an incentive to switch and this is a great forcing function.  I was uncomfortable with the fact that we were using odd (less popular) build configurations downstream.

Your question about whether "this is going to work" -- do you mean the deprecation, or the ultimate removal?  I don't see any issue w/the deprecation (though I haven't tried this patch yet).  The ultimate change to only support runtimes-style builds is planned for post LLVM-14?  That works for us, we'll start changing downstream build configs pretty soon, in ~Nov/Dec 2021.  I can't identify any objection, I am hoping/expecting there's no issues for us moving to runtimes (or formerly-known-as-runtime).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111356/new/

https://reviews.llvm.org/D111356