[libcxx-commits] [PATCH] D98006: Fixed Test for cases when DISABLE_NEW_COUNT is defined

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I *think* the intent of this patch is to be able to run these tests when the sanitizers are enabled. That would explain the difference between the tests touched by this review and those found by @Quuxplusone.

IMO we can make this change, but let's start running those tests on the sanitizers.

Also, to answer @Quuxplusone 's question, yes we do test the sanitizers on BuildKite (look for `generic-asan` & friends in `run-buildbot`).



================
Comment at: libcxx/test/std/containers/sequences/list/list.modifiers/insert_iter_size_value.pass.cpp:13
 
 // UNSUPPORTED: sanitizer-new-delete
 
----------------



================
Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/nullptr_t_deleter_throw.pass.cpp:10
 // UNSUPPORTED: no-exceptions
 // UNSUPPORTED: sanitizer-new-delete
 
----------------



================
Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/pointer_deleter_throw.pass.cpp:10
 // UNSUPPORTED: no-exceptions
 // UNSUPPORTED: sanitizer-new-delete
 
----------------



================
Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/unique_ptr.pass.cpp:9
 
 // UNSUPPORTED: sanitizer-new-delete
 
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98006/new/

https://reviews.llvm.org/D98006