[libcxx-commits] [PATCH] D111773: [libcxx] __cpp_lib_ranges value should be 201911L under C++20, not 201811L

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

@expnkx please don't remove libc++ group for libc++ patches and please don't self approve.



================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:491-494
     "name": "__cpp_lib_ranges",
-    "values": { "c++20": 201811 },
+    "values": { "c++20": 201911 },
     "headers": ["algorithm", "functional", "iterator", "memory", "ranges"],
     "unimplemented": True,
----------------
Quuxplusone wrote:
> I think this change from 201811 to 201911 is correct. I'm willing to commandeer and land this 1-character-plus-autogenerated-files change. @ldionne, thoughts?
> https://timsong-cpp.github.io/cppwp/n4861/version.syn#lib:__cpp_lib_ranges
> 
> However, notice the `"unimplemented": True`. That's correct as-is, because libc++ does //not// yet fully implement C++20 Ranges. We'll define the feature-test macro only once we have implemented the feature; that's what it's for!
IMO we should only bump it when we start/have started to work on the papers that increment this value. It might be we finish the part that requires 201811 before we finish the papers that required 201911.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111773/new/

https://reviews.llvm.org/D111773