[libcxx-commits] [PATCH] D99836: [pstl] Implement OpenMP backend

Wed Oct 13 15:54:01 PDT 2021

rarutyun added a comment.

I've put some small comments but they are definitely not a showstopper for this patch to be merged. Whoever merges it please just make sure to apply those.

Other than that, looks good to me. Remaining improvements can be done later.

================
Comment at: pstl/CREDITS.txt:22
+D: Add support for an OpenMP backend.
\ No newline at end of file

----------------
Please add new line when merge this review

================
Comment at: pstl/include/pstl/internal/omp/parallel_for.h:11
+
+#ifndef PSTL_INTERNAL_OMP_PARALLEL_FOR_H
+#define PSTL_INTERNAL_OMP_PARALLEL_FOR_H
----------------
In all (or almost all) files the guard macro is not started from underscore. It's inconsistent with the rest of the code and makes somebody think that this macro is public.

It probably doesn't deserve one more patch but I would like to make sure it's properly merged to main branch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99836/new/

https://reviews.llvm.org/D99836