[libcxx-commits] [PATCH] D110647: [SystemZ][z/OS] Resolve missing table_size symbol

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Oct 13 12:19:45 PDT 2021


jloser added inline comments.


================
Comment at: libcxx/test/std/localization/locale.categories/category.ctype/facet.ctype.special/facet.ctype.char.statics/table_size.pass.cpp:23
+  typedef std::ctype<char> F;
+  const size_t *G = &F::table_size;
+  assert(*G >= 256);
----------------
jloser wrote:
> Do we need the pointer? Or can we just say
> ```
> assert(F::table_size >= 256);
> ```
It could be a `static_assert` even, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110647/new/

https://reviews.llvm.org/D110647



More information about the libcxx-commits mailing list