[libcxx-commits] [PATCH] D111265: [libc++] Add an option to disable wide character support in libc++

[Nico Weber via Phabricator via libcxx-commits]

thakis added a comment.

This is a cool feature!

I showed it to someone (not at work) and they provided the following feedback (see comment on wchar.h). I think it's a good point so I'm forwarding it, but up to you what to do with it.



================
Comment at: libcxx/include/wchar.h:113
+#   error "The <wchar.h> header is not supported since libc++ has been configured with LIBCXX_ENABLE_WIDE_CHARACTERS disabled"
+#endif
+
----------------
"""
I know it's not my job to judge, but these lines might lead to unnecessary problems:
I assume there's quite a few build scripts that look at this and say, "hey, I've got wchar.h, why not include it"
... this is not just an assumption. libc++ does the same thing with locale.h and ncurses's c++ example files greedily include it if they find it
"""


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111265/new/

https://reviews.llvm.org/D111265