[libcxx-commits] [PATCH] D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf

[Mark de Wever via Phabricator via libcxx-commits]

Mordante updated this revision to Diff 379443.
Mordante marked an inline comment as done.
Mordante added a comment.

Test using _LIBCPP_NO_UNIQUE_ADDRESS instead of `[[no_unique_address]`.
The previous build on the Windows nodes failed due to the lack of support for this attribute.
If this fixes the issue the patch will get its own review, but this is the easiest test-case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70631/new/

https://reviews.llvm.org/D70631

Files:
  libcxx/CREDITS.TXT
  libcxx/docs/Status/Cxx17.rst
  libcxx/docs/Status/Cxx17Papers.csv
  libcxx/include/CMakeLists.txt
  libcxx/include/__charconv/ryu.h
  libcxx/include/__charconv/ryu_tables.h
  libcxx/include/__config
  libcxx/include/__iterator/counted_iterator.h
  libcxx/include/__ranges/copyable_box.h
  libcxx/include/__ranges/drop_view.h
  libcxx/include/__ranges/join_view.h
  libcxx/include/__ranges/reverse_view.h
  libcxx/include/__ranges/subrange.h
  libcxx/include/__ranges/take_view.h
  libcxx/include/__ranges/transform_view.h
  libcxx/include/charconv
  libcxx/include/module.modulemap
  libcxx/lib/abi/arm64-apple-darwin.libcxxabi.v1.stable.exceptions.no_new_in_libcxx.abilist
  libcxx/lib/abi/x86_64-apple-darwin.libcxxabi.v1.stable.exceptions.no_new_in_libcxx.abilist
  libcxx/lib/abi/x86_64-unknown-linux-gnu.libcxxabi.v1.stable.exceptions.no_new_in_libcxx.abilist
  libcxx/src/CMakeLists.txt
  libcxx/src/charconv.cpp
  libcxx/src/include/ryu/d2fixed_full_table.h
  libcxx/src/include/ryu/d2s_full_table.h
  libcxx/src/include/ryu/digit_table.h
  libcxx/src/ryu/README.txt
  libcxx/src/ryu/d2fixed.cpp
  libcxx/src/ryu/d2s.cpp
  libcxx/src/ryu/f2s.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/charconv/ryu.module.verify.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/charconv/ryu_tables.module.verify.cpp
  libcxx/test/std/utilities/charconv/charconv.msvc/double_fixed_precision_to_chars_test_cases_1.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/double_fixed_precision_to_chars_test_cases_2.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/double_fixed_precision_to_chars_test_cases_3.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/double_fixed_precision_to_chars_test_cases_4.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/double_from_chars_test_cases.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/double_general_precision_to_chars_test_cases.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/double_hex_precision_to_chars_test_cases.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/double_scientific_precision_to_chars_test_cases_1.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/double_scientific_precision_to_chars_test_cases_2.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/double_scientific_precision_to_chars_test_cases_3.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/double_scientific_precision_to_chars_test_cases_4.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/double_to_chars_test_cases.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/float_fixed_precision_to_chars_test_cases.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/float_from_chars_test_cases.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/float_general_precision_to_chars_test_cases.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/float_hex_precision_to_chars_test_cases.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/float_scientific_precision_to_chars_test_cases.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/float_to_chars_test_cases.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/floating_point_test_cases.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/test.cpp
  libcxx/test/std/utilities/charconv/charconv.msvc/test.hpp
  libcxx/test/std/utilities/charconv/charconv.msvc/test.pass.cpp