[libcxx-commits] [PATCH] D93233: [libc++] Replaces std::sort by Bitset sorting algorithm.

Mon Oct 11 10:17:09 PDT 2021

ldionne added a comment.

In D93233#3047865 <https://reviews.llvm.org/D93233#3047865>, @nilayvaish wrote:

> In D93233#3046799 <https://reviews.llvm.org/D93233#3046799>, @ldionne wrote:
>
>> - Rebase onto main
>> - Keep the old std::sort implementation around for ABI compatibility
>> - Do not explicitly instantiate bitset sort in the library -- that ties our hands too much
>>
>> Still left to do:
>>
>> - Some tests are failing, they need to be investigated
>> - Do basic code size testing since we're not instantiating the sorts in the dylib anymore -- does it cause the size of user programs to blow up badly?
>> - Make sure I applied the diff correctly - I had to do it manually but the diff was generated weirdly, so I'm not sure the diff I applied is correct.
>> - We need to decide on the visibility of implementation detail functions. We probably want to sprinkle `_LIBCPP_HIDE_FROM_ABI` all around.
>>
>> Ideally @minjaehwang if you could commandeer this again and make those fixes, that would be awesome. From here on, it should be fairly straightforward to make changes until we can ship this, since I should have handled most of the annoying libc++ specific things.
>
> ldionne@, I'll work on this on MinJae's behalf.  Would post a new diff sometime soon.

Awesome, thanks! I saw your post on `libcxx-dev` just now. To reproduce CI failures locally, you can use `libcxx/utils/ci/run-buildbot-container` to spawn a Docker container matching our CI nodes, and then `libcxx/utils/ci/run-buildbot <config you want>` to run the actual build/test. There's documentation in `run-buildbot-container` and also the `Dockerfile` in the same directory.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93233/new/

https://reviews.llvm.org/D93233